fix(vite-plugin): Ensure post order of sentry-vite-release-injection-plugin to avoid breaking @rollup/plugin-commonjs step
#578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-plugin` to avoid breaking `@rollup/plugin-commonjs` step
lforst
approved these changes
Jul 29, 2024
This was referenced Sep 3, 2024
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
This was referenced Sep 24, 2024
Closed
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't really find any good way of testing this so I just relied on manual testing with the user submitted reproduction in #552 as well as trying it out in two sample apps, a react app and a solid app which built and uploaded sourcemaps fine.
Closes: #552